Mr Mirchi Posted February 17, 2020 Report Posted February 17, 2020 jeevitham edho best practice ooo endhi kaadho na royyaa artham kadhu okko saari okkoditho work cheseppudu web page lo oka table lo oka column hide cheyali....server side lo dataRowTable object lo oka line comment cheyali ..so chesaaa( double slash tho) ..future lo evadanna aa line chusthe e column vundedhi but remove ani artham avudhi ani in case malli add cheyamante adhe column ni...maa lead gadu vachi code chala clean ga vundaali ,, aa line remove cheyyi annaadu....theera chusthe proj lo vaadu comment chesina code chala places vunnavi.......nuvvu best practice not following antaadu...... Quote
Rushabhi Posted February 17, 2020 Report Posted February 17, 2020 Column teesesthe poorthiga remove cheyyi. If you comment it future lo vachevadiki adhi comment enduku chesaru should it be removed was it mistakenly commented, should it not be removed inni questions vasthayi. Ideally each code change should be backed up by requirements Quote
Rushabhi Posted February 17, 2020 Report Posted February 17, 2020 And if your lead is also doing the same and asking you to not do it, vaadi code reviews lo nuvvu comment pettu to delete the commented our code ani Quote
dasari4kntr Posted February 17, 2020 Report Posted February 17, 2020 I think u should remove the Code comment completely.... Git history will preserve the old code... if your manager is not doing and only preaching you...that means he is hypocrite Quote
Rushabhi Posted February 17, 2020 Report Posted February 17, 2020 Read Robert C Martin clean code book. You will get to know a lot of best practices Quote
sattipandu Posted February 17, 2020 Report Posted February 17, 2020 With Git coming into picture the standards for such things have changed earlier cvs or svn vaadeppudu atla chesthundey // commenting now just remove that line and mention the reason for removing that line in the PR Name and the comment for that PR this way code looks clean and also if any developer wants to pull history it will be quite evident as to what line was removed when and the PR made for this and the justification (version one story number or Jira number) cheeerio Quote
Scada Posted February 17, 2020 Report Posted February 17, 2020 Ma team lo nenu and ma architect iddaram a devs.. itlanti kastalu undavu and mem idaram minimum pattinchukomu Quote
Jombo0108 Posted February 17, 2020 Report Posted February 17, 2020 ma team lead ni pakkaki 10gu annadu dev manager. pillalni misguide chestunnv aniii Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.