CurryDi Posted August 21, 2020 Report Posted August 21, 2020 if a guy adds random and silly comments on PR what should we do ? Quote
dasari4kntr Posted August 21, 2020 Report Posted August 21, 2020 21 minutes ago, CurryDi said: if a guy adds random and silly comments on PR what should we do ? bitbucket lo aithe hooks and few plugins vuntai.. it doesnt allow to remote push if it didnt follow the pattern...in the first place... hope there are plugins there... for the same purpose in gitlab as well... 1 Quote
Spartan Posted August 21, 2020 Report Posted August 21, 2020 1 hour ago, dasari4kntr said: bitbucket lo aithe hooks and few plugins vuntai.. it doesnt allow to remote push if it didnt follow the pattern...in the first place... hope there are plugins there... for the same purpose in gitlab as well... git lo kuda chala unnai 1 Quote
dasari4kntr Posted August 22, 2020 Report Posted August 22, 2020 On 8/21/2020 at 7:43 PM, Spartan said: git lo kuda chala unnai You mean github..? yes github has plenty of plugins... but enterprises using bitbucket and gitlab...mostly.. not sure apart from these three any other git servers...share if any Quote
vachesa Posted August 22, 2020 Report Posted August 22, 2020 3 hours ago, CurryDi said: if a guy adds random and silly comments on PR what should we do ? just tell him not to do but like others said you can set a mandatory pattern like have ticket# or words like release etc etc but seriously once the format is satisfied nothing stops from adding whatever they want if the intention is to be naughty. junior ithe back meeda okati ichi sakkaga comments pettamanu, senior ithe skip the back part or andaru vunna meeting lo suggest it that we should all follow better commenting structure blah blah Still no change ante just don't approve it and move on to others and when they bring it up you can say I have no idea what those comments mean ani 1 Quote
Amrita Posted August 22, 2020 Report Posted August 22, 2020 3 hours ago, CurryDi said: if a guy adds random and silly comments on PR what should we do ? Just comment back justifying why you did it that way . Better approach blah blah blah . Senseless comment ayite oka URL documentation link pettu . Slipper shot I do it all the time . Eventually he will be careful when commenting on your code as he will look like an idiot . 1 Quote
k2s Posted August 22, 2020 Report Posted August 22, 2020 5 hours ago, CurryDi said: if a guy adds random and silly comments on PR what should we do ? Resolve the comments with ‘by design’ or ‘wont fix’ 1 Quote
dasari4kntr Posted September 1, 2020 Report Posted September 1, 2020 On 8/21/2020 at 6:14 PM, CurryDi said: if a guy adds random and silly comments on PR what should we do ? Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.